rhtyd commented on a change in pull request #4094:
URL: https://github.com/apache/cloudstack/pull/4094#discussion_r430310804
##########
File path: scripts/storage/qcow2/managesnapshot.sh
##########
@@ -153,7 +153,7 @@ destroy_snapshot() {
lvm lvremove -f "${vg}/${snapshotname}-cow"
elif [ -f $disk ]; then
#delete all the existing snapshots
- $qemu_img snapshot -l $disk |tail -n +3|awk '{print $1}'|xargs -I {}
$qemu_img snapshot -d {} $disk >&2
+ $qemu_img snapshot -l $disk |tail -n +3|awk '{print $2}'|xargs -I {}
$qemu_img snapshot -d {} $disk >&2
Review comment:
@DaanHoogland I think we'll have to check the command for our snapshots,
when we create them we generally pass like a uuid-looking name. @shwstppr
@davidjumani can you test and confirm (with centos7 vs centos8) with this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
