ServiceTo opened a new pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109
## Description `/opt/cloud/bin/setup_heartbeat_sr.sh` line 75 tests for “XenServer release 7.” in `/etc/redhat-release` which contains “XCP-ng release 8.0.0 (xenenterprise)” in my case so the `lvcreate` statement doesn’t contain the required options <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> Fixes: #3281 ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> Adding an iSCSI endpoint now succeeds with XCP-ng 8.0.0. I've left the previous XenServer logic alone just added the XCP-ng test case into the else block. This could definitely be fine tuned by someone who's more intimate with these scripts but I just wanted the issue fixed without interfering in the logic. <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
