Spaceman1984 commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r442870662
##########
File path:
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##########
@@ -219,7 +219,7 @@ public long download(boolean resume,
DownloadCompleteCallback callback) {
} catch (IOException ioe) {
status = TemplateDownloader.Status.UNRECOVERABLE_ERROR; //probably
a file write error?
// Let's not overwrite the original error message.
- if (errorString.isEmpty()){
+ if (errorString.equals(" ")){
Review comment:
What if we get rid of the check altogether and append the error message
to what was there already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
