DaanHoogland commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r438706146
##########
File path:
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##########
@@ -219,7 +219,7 @@ public long download(boolean resume,
DownloadCompleteCallback callback) {
} catch (IOException ioe) {
status = TemplateDownloader.Status.UNRECOVERABLE_ERROR; //probably
a file write error?
// Let's not overwrite the original error message.
- if (errorString.isEmpty()){
+ if (errorString.equals(" ")){
Review comment:
i'd go for `errorString.trim().isEmpty()` to be honest (to be more
defensive, but this should work as well. And it might be wise to alter the
initialisation statement as well???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
