RodrigoDLopez commented on pull request #4111:
URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-646838607
Hello Gabriel, nice feature.
I did some manual testing, and it seems to me that everything is correct.
**Environment**
- 2 Hosts KVM with HA enable
- H01
- H02
- Local and shared storage
**Test 01**
- Try to declare an enable host as dead
**Expected:** Do nothing, and inform this on response
**Result:** as expected the API responds "Cannot perform declare host [id=1,
name=kvm413] as 'Dead' when host is in Up status"
**Test 02**
- Try to cancel host declared as dead on an enable host
**Expected:** Do nothing, and infor this on response
**Result:** as expected the API responds "Failed to Cancel host from Dead
status due to: Cannot perform cancelHostAsDead on host [id=1, name=kvm413] when
host is in Enabled state"
**Test 03**
- migrate VR to H01
- deploy 1 vm with HA enable on H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Migrate VR and instance to a suitable host.
**Result:** all good, as expected
**Test 04**
- deploy 2 vms with HA enable on H01
- deploy 1 vms without HA enable on H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Vms with HA enable migrate to a suitable host, vm without HA
enable stay in stopped state
**Result:** as expected, vms with HA enable was placed at a suitable host,
vms without HA enable, need to be wake up manualy
**Test 05**
- migrate ssvm, cpvm and vr to H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Migrate ssvm, cpvm and vr to a suitable host
Result: As expected those instances was migrated to a suitable host.
**Test 06**
- disable HA on H01 and H02
- deploy 2 vms with HA enable on H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** I dont know what is the expected behavior here.
**Result:** Migrate those instances to a suitable host
**Test 07**
- disable HA on H01 and H02
- migrate ssvm, cpvm, vr to H01
- stop agent on H01
- deal with instances at H01
- declare H01 as dead
**Expected:** Migrate those instances to a suitable host.
**Result:** Migrate those instances to a suitable host
LGTM based on this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
