DaanHoogland commented on a change in pull request #4116:
URL: https://github.com/apache/cloudstack/pull/4116#discussion_r443030410
##########
File path:
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
##########
@@ -300,8 +294,7 @@ private boolean
isKubernetesServiceTemplateConfigured(DataCenter zone) {
LOGGER.warn(String.format("Unable to find the template %s to
be used for provisioning Kubernetes cluster nodes", templateName));
return false;
}
- List<VMTemplateZoneVO> listZoneTemplate =
templateZoneDao.listByZoneTemplate(zone.getId(), template.getId());
- if (listZoneTemplate == null || listZoneTemplate.isEmpty()) {
+ if
(CollectionUtils.isEmpty(templateJoinDao.newTemplateView(template,
zone.getId(), true))) {
Review comment:
The call `public List<TemplateJoinVO>
newTemplateView(VirtualMachineTemplate template, long zoneId, boolean
readyOnly)` as implemented in `TemplateJoinDaoImpl`, does a search including
removed leading to a hit for a template that is not available. Is this intended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
