rhtyd commented on a change in pull request #4176:
URL: https://github.com/apache/cloudstack/pull/4176#discussion_r445503244
##########
File path: server/src/main/java/com/cloud/api/ApiServlet.java
##########
@@ -213,7 +213,7 @@ void processRequestInContext(final HttpServletRequest req,
final HttpServletResp
try {
responseString =
apiAuthenticator.authenticate(command, params, session, remoteAddress,
responseType, auditTrailSb, req, resp);
if (session != null &&
session.getAttribute(ApiConstants.SESSIONKEY) != null) {
- resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
+ resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly;Path=/client", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
Review comment:
@davidjumani in a deploy trillian env with this PR (or you may use the
primate-qa server as well which has this PR) and both old UI and Primate, can
you check side-effects when you change the context in
/etc/cloudstack/management/server.properties from `/client/` to say (a)
`/somenew-path` and (b) `/` and restart management server and try log-in in
both legacy UI and Primate (check network an Application/cookies)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
