sureshanaparti commented on a change in pull request #4172:
URL: https://github.com/apache/cloudstack/pull/4172#discussion_r448110054
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -2412,6 +2419,23 @@ public void ensureScsiDeviceControllers(int count, int
availableBusNum) throws E
}
}
+ private boolean isValidScsiDiskController(VirtualSCSIController
scsiDiskController) {
+ if (scsiDiskController == null) {
+ return false;
+ }
+
+ List<Integer> scsiDiskDevicesOnController =
scsiDiskController.getDevice();
+ if (scsiDiskDevicesOnController != null &&
scsiDiskDevicesOnController.size() >=
(VmwareHelper.MAX_SUPPORTED_DEVICES_SCSI_CONTROLLER)) {
Review comment:
> Maybe also a null check for scsiDiskDevicesOnController?
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
