GabrielBrascher commented on a change in pull request #4219:
URL: https://github.com/apache/cloudstack/pull/4219#discussion_r457944776
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiStorageCleanupMonitor.java
##########
@@ -114,7 +114,7 @@ private void
updateDiskStatusMapWithInactiveIscsiSessions(Connect conn){
//check the volume map. If an entry exists change the
status to True
for (final LibvirtVMDef.DiskDef disk : disks) {
- if (diskStatusMap.containsKey(disk.getDiskPath())) {
+ if
(diskStatusMap.containsKey(disk.getDiskPath())&&!disk.getDiskPath().contains("part"))
{
Review comment:
Can you please extract `"part"` to a constant?
(Maybe) Adding some details/documentation on why it is important to have the
disk path checked with that constant might be a plus as well considering future
reference/maintenance on the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
