rafaelweingartner commented on a change in pull request #4194:
URL: https://github.com/apache/cloudstack/pull/4194#discussion_r460517231
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -3207,30 +3208,13 @@ public DiskOffering updateDiskOffering(final
UpdateDiskOfferingCmd cmd) {
diskOffering.setDisplayOffering(displayDiskOffering);
}
- // Note: tag editing commented out for now;keeping the code intact,
- // might need to re-enable in next releases
- // if (tags != null)
- // {
- // if (tags.trim().isEmpty() && diskOfferingHandle.getTags() == null)
- // {
- // //no new tags; no existing tags
- // diskOffering.setTagsArray(csvTagsToList(null));
- // }
- // else if (!tags.trim().isEmpty() && diskOfferingHandle.getTags() !=
- // null)
- // {
- // //new tags + existing tags
- // List<String> oldTags = csvTagsToList(diskOfferingHandle.getTags());
- // List<String> newTags = csvTagsToList(tags);
- // oldTags.addAll(newTags);
- // diskOffering.setTagsArray(oldTags);
- // }
- // else if(!tags.trim().isEmpty())
- // {
- // //new tags; NO existing tags
- // diskOffering.setTagsArray(csvTagsToList(tags));
- // }
- // }
+ if (tags != null){
+ if(tags.isBlank()){
Review comment:
I see what you did now. I created a method to remove the tags by sending
blank spaces. Can you extract this to a method? Then, document it, and create
unit tests? Also, we need an end-user documentation for this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
