ravening commented on a change in pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#discussion_r462514784
##########
File path:
server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -348,11 +362,19 @@ private void setupAgentSecurity(final Connection
sshConnection, final String age
_hostDao.saveDetails(connectedHost);
return resources;
} catch (DiscoveredWithErrorException e) {
+ s_logger.error("Exception: "+ e.getMessage());
Review comment:
I have no idea why it's there in first place. So I'm displaying message
whatever we catch
##########
File path:
server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -348,11 +362,19 @@ private void setupAgentSecurity(final Connection
sshConnection, final String age
_hostDao.saveDetails(connectedHost);
return resources;
} catch (DiscoveredWithErrorException e) {
+ s_logger.error("Exception: "+ e.getMessage());
throw e;
} catch (Exception e) {
String msg = " can't setup agent, due to " + e.toString() + " - "
+ e.getMessage();
s_logger.warn(msg);
} finally {
+ // set guid to null once host is added
Review comment:
Initialguid will always beer null since I'm fetching the value for a
removed host. For non removed hosts it will be non null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
