rhtyd commented on a change in pull request #4274:
URL: https://github.com/apache/cloudstack/pull/4274#discussion_r472910416
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2529,7 +2529,7 @@ public Network doInTransaction(final TransactionStatus
status) {
* @param ntwkOff network offering
*/
private boolean hasGuestBypassVlanOverlapCheck(final boolean
bypassVlanOverlapCheck, final NetworkOfferingVO ntwkOff, final boolean
isPrivateNetwork) {
- return bypassVlanOverlapCheck && (ntwkOff.getGuestType() ==
GuestType.Shared || isPrivateNetwork);
+ return bypassVlanOverlapCheck && (ntwkOff.getGuestType() ==
GuestType.Shared || ntwkOff.getGuestType() == GuestType.L2 || isPrivateNetwork);
Review comment:
Yes that works as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
