rhtyd opened a new pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326
This handle edge cases of upgrades and when legacy UI is used along with
Primate or any UI sharing cookies. The specific case it fixes involves
removal of duplicate sessionkey cookies.
Fixes #4324
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the
boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
1. Logout and create a fake sessionkey cookie using `$.cookie('sessionkey',
'123')`
2. Try to login, login will fail and in the request two sessionkey cookies
will be seen passed:
With the fix, when logout is called the API will clear sessionkey cookie
(which is httponly so only the backend/server can remove it); and login works.
This will cover issues after upgrades and when using legacy UI with Primate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
