weizhouapache commented on a change in pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#discussion_r493297124
########## File path: api/src/main/java/com/cloud/agent/api/to/LoadBalancerConfigTO.java ########## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package com.cloud.agent.api.to; + +import com.cloud.network.rules.LoadBalancerConfig; Review comment: > should we use org.apache.cloudstack as base packages for new classes? @DaanHoogland all TO files are put into api/src/main/java/com/cloud/agent/api/to/, maybe we can move them together ``` # ls -l api/src/main/java/com/cloud/agent/api/to/ total 160 -rw-r--r-- 1 root root 2951 Sep 3 09:35 DatadiskTO.java -rw-r--r-- 1 root root 912 Sep 22 14:35 DataObjectType.java -rw-r--r-- 1 root root 1021 Sep 3 09:35 DataStoreTO.java -rw-r--r-- 1 root root 1125 Sep 3 09:35 DataTO.java -rw-r--r-- 1 root root 1826 Sep 3 09:35 DhcpTO.java -rw-r--r-- 1 root root 3063 Sep 3 09:35 DiskTO.java -rw-r--r-- 1 root root 1280 Sep 3 09:35 DpdkTO.java -rw-r--r-- 1 root root 9205 Sep 3 09:35 FirewallRuleTO.java -rw-r--r-- 1 root root 1930 Sep 3 09:35 GPUDeviceTO.java -rw-r--r-- 1 root root 2749 Sep 3 09:35 HostTO.java -rw-r--r-- 1 root root 3576 Sep 3 09:35 IpAddressTO.java -rw-r--r-- 1 root root 1361 Sep 22 14:41 LoadBalancerConfigTO.java -rw-r--r-- 1 root root 22026 Sep 22 14:41 LoadBalancerTO.java -rw-r--r-- 1 root root 1983 Sep 3 09:35 MonitorServiceTO.java -rw-r--r-- 1 root root 4209 Sep 3 09:35 NetworkACLTO.java -rw-r--r-- 1 root root 5352 Sep 3 09:35 NetworkTO.java -rw-r--r-- 1 root root 1966 Sep 23 08:12 NfsTO.java -rw-r--r-- 1 root root 3105 Sep 3 09:35 NicTO.java -rw-r--r-- 1 root root 2199 Sep 3 09:35 PortForwardingRuleTO.java -rw-r--r-- 1 root root 9934 Sep 3 09:35 S3TO.java -rw-r--r-- 1 root root 2930 Sep 3 09:35 StaticNatRuleTO.java -rw-r--r-- 1 root root 2058 Sep 3 09:35 StorageFilerTO.java -rw-r--r-- 1 root root 2256 Sep 3 09:35 SwiftTO.java -rw-r--r-- 1 root root 1718 Sep 3 09:35 TemplateTO.java -rw-r--r-- 1 root root 10206 Sep 23 08:10 VirtualMachineTO.java -rw-r--r-- 1 root root 5387 Sep 3 09:35 VolumeTO.java ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
