[GitHub] [cloudstack] weizhouapache commented on pull request #4379: Add global configuration for max cpu/ram in service offerings

Tue, 06 Oct 2020 07:59:08 -0700 


weizhouapache commented on pull request #4379:
URL: https://github.com/apache/cloudstack/pull/4379#issuecomment-704328638


   > LGTM
   > Verified the fix:
   > 
   > 1. Set "vm.serviceoffering.cpu.cores.max" to 2 and attempted to create a 
compute offering with CPU cores set to 4 - Failed (as expected)
   >    
![image](https://user-images.githubusercontent.com/10495417/95209215-bfc3b700-0807-11eb-9cf4-2dab42efdb4a.png)
   > 2. Set "vm.serviceoffering.ram.size.max" to 200 and attempted to create a 
service offering with memory of 500 MB - Failed (as expected)
   >    
![image](https://user-images.githubusercontent.com/10495417/95209402-ef72bf00-0807-11eb-9c75-a07d1e7d1e3c.png)
   > 3. Created a service offering within the defined limits of 
vm.serviceoffering.cpu.cores.max = 2 and vm.serviceoffering.ram.size.max = 200 
- Passed (as expected)
   
   thanks @Pearl1594 !
   Could you also test dynamic offerings (constrained and unconstrained) ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to