DaanHoogland commented on a change in pull request #4396:
URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503831503
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String
hostName, List<? extends N
// * verify that there are no duplicates
if (hostNames.contains(hostName)) {
throw new InvalidParameterValueException("The vm with
hostName " + hostName + " already exists in the network domain: " +
ntwkDomain.getKey() + "; network="
- + _networkModel.getNetwork(ntwkId));
+ + _networkModel.getNetwork(ntwkId).getName());
Review comment:
> @DaanHoogland we are iterating over the list of networks which got
populated earlier and it contains only valid existing networks. so networkmodel
shouldnt return null
Maybe so @ravening, i trust your judgement on that. But it didn't happen in
this method, so there is no telling what future generations will make of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
