ravening commented on a change in pull request #4396:
URL: https://github.com/apache/cloudstack/pull/4396#discussion_r506442381
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String
hostName, List<? extends N
// * verify that there are no duplicates
if (hostNames.contains(hostName)) {
throw new InvalidParameterValueException("The vm with
hostName " + hostName + " already exists in the network domain: " +
ntwkDomain.getKey() + "; network="
- + _networkModel.getNetwork(ntwkId));
+ + _networkModel.getNetwork(ntwkId).getName());
Review comment:
> @ravening while it does make sense to show the network name, we do not
ensure uniqueness in network names in CloudStack - so would it lead to
ambiguity just showing the name?
@Pearl1594 this exception is thrown when we are trying to create second VM
with same in same network. So I would assume, user will know in which network
he is creating the VM. Also even if the network name is not unique, it's better
than displaying VO object right which won't make sense anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
