Spaceman1984 commented on a change in pull request #4401:
URL: https://github.com/apache/cloudstack/pull/4401#discussion_r504513407
##########
File path:
server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
##########
@@ -1598,65 +1602,73 @@ public LoadBalancer createPublicLoadBalancerRule(String
xId, String name, String
// LoadBalancer result = _elbMgr.handleCreateLoadBalancerRule(lb,
// lbOwner, lb.getNetworkId());
LoadBalancer result = null;
- if (result == null) {
- IpAddress systemIp = null;
- NetworkOffering off = _entityMgr.findById(NetworkOffering.class,
network.getNetworkOfferingId());
- if (off.isElasticLb() && ipVO == null && network.getVpcId() ==
null) {
- systemIp = _ipAddrMgr.assignSystemIp(networkId, lbOwner, true,
false);
- if (systemIp != null) {
- ipVO = _ipAddressDao.findById(systemIp.getId());
+ IpAddress systemIp = null;
+ NetworkOffering off = _entityMgr.findById(NetworkOffering.class,
network.getNetworkOfferingId());
+
+ if (srcPortStart == 53) {
Review comment:
I tested port 8081 and it threw an error, seems like there is already
some code somewhere that checks for certain ports, I'll see if I should move my
code there as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
