weizhouapache commented on a change in pull request #4359:
URL: https://github.com/apache/cloudstack/pull/4359#discussion_r508235074
##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -3938,7 +3938,12 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
}
// update password for this host
final DetailVO nv = _detailsDao.findDetail(h.getId(),
ApiConstants.USERNAME);
- if (nv.getValue().equals(command.getUsername())) {
+ if (nv == null) {
+ final DetailVO nvu = new DetailVO(h.getId(),
ApiConstants.USERNAME, command.getUsername());
Review comment:
@sureshanaparti @ravening we had the issue in the past that Removed kvm
host is added back to cloudstack when cloudstack-agent is started. in that
case, there is no username/password saved in host_details for the host (because
the entries are removed from db when host is removed, but not added back).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
