ravening commented on pull request #4359:
URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-714313317
> > > > @sureshanaparti I need clear picture what you are looking for
exactly. Once you clarify that I can look into it.
> > >
> > >
> > > @ravening As per the PR changes, when there is no "username" detail in
the _host_details_ table, the "username" and "password" are persisted from the
updateHostPassword API input, which are not null, but can be empty. Persisting
the password with username empty doesn't make sense. So, ensure that username
is not empty, when persisting "username" and "password". Thanks.
> >
> >
> > @sureshanaparti per my understanding, we should add a check before db
transaction.
> > ```
> > if (StringUtils.isBlank(cmd.getUserName()) {
> > throw InvalidParameterValueException("aaaaa");
> > }
> > ```
> >
> >
> > is this what you mean ?
>
> @weizhouapache yes, you got it. thanks.
@sureshanaparti I have made the changes. Please review it again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
