GabrielBrascher commented on a change in pull request #4034:
URL: https://github.com/apache/cloudstack/pull/4034#discussion_r509010619
##########
File path:
engine/schema/src/main/resources/META-INF/db/schema-41310to41400-cleanup.sql
##########
@@ -25,4 +25,4 @@ DELETE FROM `cloud`.`configuration` WHERE name =
'host.maintenance.retries';
UPDATE `cloud`.`storage_pool` SET path="/var/lib/libvirt/images" WHERE
path="/var/lib/libvirt/images/";
-- remove (one of) duplicate unique indexes from Region table
-ALTER TABLE `region` DROP INDEX `id_3`;
+ALTER TABLE `region` DROP INDEX IF EXISTS `id_3`;
Review comment:
Mysql documentation
(https://dev.mysql.com/doc/refman/5.7/en/drop-index.html):
```
DROP INDEX [ONLINE | OFFLINE] index_name ON tbl_name
[algorithm_option | lock_option] ...
algorithm_option:
ALGORITHM [=] {DEFAULT | INPLACE | COPY}
lock_option:
LOCK [=] {DEFAULT | NONE | SHARED | EXCLUSIVE}
```
MariaDB:
```
DROP INDEX [IF EXISTS] index_name ON tbl_name
[WAIT n |NOWAIT]
[algorithm_option | lock_option] ...
algorithm_option:
ALGORITHM [=] {DEFAULT|INPLACE|COPY|NOCOPY|INSTANT}
lock_option:
LOCK [=] {DEFAULT|NONE|SHARED|EXCLUSIVE}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
