DaanHoogland commented on a change in pull request #4428:
URL: https://github.com/apache/cloudstack/pull/4428#discussion_r512728192
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
##########
@@ -128,9 +131,15 @@ protected EndPoint findEndPointInScope(Scope scope, String
sqlBase, Long poolId)
}
}
+ List<Long> dedicatedHosts = dedicatedResourceDao.listAllHosts();
+
// TODO: order by rand() is slow if there are lot of hosts
sbuilder.append(") t where t.value<>'true' or t.value is null");
//Added for exclude cluster's subquery
- sbuilder.append(" ORDER by rand() limit 1");
+ sbuilder.append(" ORDER by ");
+ for (Long hostId: dedicatedHosts){ // put dedicated hosts at the end
of the result set
+ sbuilder.append("field(t.id, '" + hostId +"')," );
+ }
+ sbuilder.append(" rand() limit 1");
Review comment:
so why this complicated way to filter out specific values? It isn't very
readible and we can add tham to the where clause as `not t.id in (<hostID>,
...)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
