ravening opened a new pull request #4448:
URL: https://github.com/apache/cloudstack/pull/4448
## Description
<!--- Describe your changes in detail -->
Make internaldns1 optional for zone creation
As of now internaldns1 is mandatory field while creating
a zone. Sometimes we dont have internaldns1 and so make
this field as optional
Since this is optional, the original behaviour is still retained and nothing
breaks
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the
boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
<!-- see how your change affects other areas of the code, etc. -->
Before the change
```
(local) mgt01 > create zone
Missing arguments: networktype internaldns1 dns1 name
(local) mgt01 >
```
After the change
```
(local) 🐱 > create zone
💩 Missing required parameters: dns1, name, networktype
(local) 🐱 >
```
In systemvms
```
root@s-175-VM:~# cat /etc/resolv.conf
nameserver 8.8.4.4
nameserver 8.8.8.8
root@s-175-VM:~# vi /var/log/messages
root@s-175-VM:~# cat /etc/dnsmasq-resolv.conf
nameserver 8.8.4.4
nameserver 8.8.8.8
```
After destroying
```
root@s-176-VM:~# cat /etc/resolv.conf
nameserver 8.8.8.8
root@s-176-VM:~#
root@s-176-VM:~# cat /etc/dnsmasq-resolv.conf
nameserver 8.8.8.8
root@s-176-VM:~#
```
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
