ravening opened a new pull request #4452:
URL: https://github.com/apache/cloudstack/pull/4452
## Description
<!--- Describe your changes in detail -->
Many of the searching conditions are not considered when
template id is passed but they are considered only when
template id is not passed. Move other conditions out of else
part so that they will be considered when id is passed.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the
boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
<!-- see how your change affects other areas of the code, etc. -->
Without changes
```
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor,
id="45be18c7-c0fd-11ea-ba74-067606003392"
{
"count": 1,
"template": [
{
"hypervisor": "KVM",
"id": "45be18c7-c0fd-11ea-ba74-067606003392"
}
]
}
(local) mgt01 >
(local) mgt01 >
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor,
id="45be18c7-c0fd-11ea-ba74-067606003392" hypervisor=XenServer
{
"count": 1,
"template": [
{
"hypervisor": "KVM",
"id": "45be18c7-c0fd-11ea-ba74-067606003392"
}
]
}
```
With changes
```
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor
id="d9411172-3832-4fc9-a771-39514e0a9faa" hypervisor=KVM
{
"count": 1,
"template": [
{
"hypervisor": "KVM",
"id": "d9411172-3832-4fc9-a771-39514e0a9faa"
}
]
}
(local) mgt01 > list templates templatefilter=all filter=id,hypervisor
id="d9411172-3832-4fc9-a771-39514e0a9faa" hypervisor=XenServer
(local) mgt01 >
```
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
