slavkap commented on issue #4450:
URL: https://github.com/apache/cloudstack/issues/4450#issuecomment-723831176
I could fix this issue, but I'm not very familiar with this part of
CloudStack. Do we have to provide isolation method for basic network? For basic
network the vlanId has to be null according to the code, and
encodeVlanIdIntoBroadcastUri() will be executed
```
if (vlanId == null) {
vlanId = Vlan.UNTAGGED;
} else {
if (!vlanId.equalsIgnoreCase(Vlan.UNTAGGED)) {
throw new InvalidParameterValueException("Only vlan " +
Vlan.UNTAGGED + " can be created in " + "the zone of type " +
NetworkType.Basic);
}
}
```
or only we need to check that the list is empty when encoding the vlan
` if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
