davidjumani opened a new pull request #4459: URL: https://github.com/apache/cloudstack/pull/4459
## Description Downloads images int the network and dashboard yaml while creating the kubernetes binaries iso This step was skipped, so bringing up a cluster on a node that does not have access to the internet failed ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? ``` ./create-kubernetes-binaries-iso.sh ./ 1.11.4 0.7.1 1.11.1 https://github.com/weaveworks/weave/releases/download/latest_release/weave-daemonset-k8s-1.11.yaml https://raw.githubusercontent.com/kubernetes/dashboard/v1.10.0/src/deploy/recommended/kubernetes-dashboard.yaml .......... Downloading docker image k8s.gcr.io/kube-apiserver-amd64:v1.11.4 --- Downloading docker image k8s.gcr.io/kube-controller-manager-amd64:v1.11.4 --- Downloading docker image k8s.gcr.io/kube-scheduler-amd64:v1.11.4 --- Downloading docker image k8s.gcr.io/kube-proxy-amd64:v1.11.4 --- Downloading docker image k8s.gcr.io/pause:3.1 --- Downloading docker image k8s.gcr.io/etcd-amd64:3.2.18 --- Downloading docker image k8s.gcr.io/coredns:1.1.3 --- Downloading docker image weaveworks/weave-kube:2.7.0 --- << Added image from network yaml Downloading docker image weaveworks/weave-npc:2.7.0 --- << Added image from network yaml Downloading docker image k8s.gcr.io/kubernetes-dashboard-amd64:v1.10.0 --- << Added image from dashboard yaml ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
