DaanHoogland commented on a change in pull request #4459:
URL: https://github.com/apache/cloudstack/pull/4459#discussion_r526034361
##########
File path: scripts/util/create-kubernetes-binaries-iso.sh
##########
@@ -16,9 +16,11 @@
# specific language governing permissions and limitations
# under the License.
+set -e
Review comment:
:tr: red flag ;) but fine by me. we allow this script to exit and leave
garbage behind. in view of the function of this script fine. (a comment or so
would be appropriate, i think)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
