DaanHoogland commented on a change in pull request #4467:
URL: https://github.com/apache/cloudstack/pull/4467#discussion_r522763710
##########
File path:
server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
##########
@@ -834,4 +837,11 @@ public boolean postStateTransitionEvent(final
StateMachine2.Transition<State, Vi
// once from VpcVirtualNetworkApplianceManagerImpl and once from
VirtualNetworkApplianceManagerImpl itself
return true;
}
+
+ private Nic getNicWithUpdatedDeviceId(final long nicId, int deviceId) {
+ NicVO nic = _nicDao.findById(nicId);
+ nic.setDeviceId(deviceId);
+ _nicDao.update(nic.getId(), nic);
+ return nic;
+ }
Review comment:
yes, fine. the only problem i have is with my own spelling;
`getNicAndUpdtaeDeviceId()` misses a 'k' ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
