samzehnder opened a new issue #4472:
URL: https://github.com/apache/cloudstack/issues/4472
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete
the comments.
-->
##### ISSUE TYPE
* Improvement Request
* Enhancement Request
* Feature Idea
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
Configurable VMware Config Spec for hotadd actions in virtual machines in
VMware 6.7+ environments.
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master
branch.
-->
~~~
6.15
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network,
advanced networking, etc. N/A otherwise
-->
vSphere 6.7
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
N/A
##### SUMMARY
<!-- Explain the problem/feature briefly -->
Some virtual machines should not be configured with hotadd support. Before
vSphere 6.7 it is possible to overwrite the config via instance details, which
are then translated to vmware extraOptionConfig (i.e. vcpu.hotadd=false).
Since vSphere 6.7 this is no longer supported, as the hotadd feature is not
an extraOption anymore, but a vmSpecConfig, and this get's set by CloudStack
based on OS-type (s.
[VmwareResource.java](https://github.com/apache/cloudstack/blob/7f408ec967327a152d903dcc55260ccff9bad0fd/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L1961))
General idea is, to use the instance details to control the settings, i.e.
if vcpu.hotadd=false is set in instance details, then set hotadd feature for
vCPU to false as well in vmConfigSpec.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal
test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
Instance detail is added with key=>value: vcpu.hotadd=>false
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
Above details get's translated to VM Spec Config:
vmConfigSpec.setCpuHotAddEnabled(False)
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
Setting hotadd feature is only based on guest os descriptor.
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
