sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r524254789
##########
File path: engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java
##########
@@ -59,7 +59,13 @@
"The default label name for the config drive", false);
ConfigKey<Boolean> VmConfigDriveOnPrimaryPool = new
ConfigKey<>("Advanced", Boolean.class, "vm.configdrive.primarypool.enabled",
"false",
- "If config drive need to be created and hosted on primary storage
pool. Currently only supported for KVM.", true);
+ "If config drive need to be created and hosted on primary storage
pool. Currently only supported for KVM.", true, ConfigKey.Scope.Zone);
Review comment:
> @sureshanaparti this config is changed from global scope to zone. Will
that affect the existing setup in any way?
@shwstppr no, the existing config would always fallback to the global scope,
as zone scope setting is not defined initially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
