Spaceman1984 commented on a change in pull request #4425:
URL: https://github.com/apache/cloudstack/pull/4425#discussion_r526111484
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -587,6 +590,7 @@ protected Answer copySnapshot(DataObject srcData,
DataObject destData) {
if (cacheData != null) {
cacheMgr.deleteCacheObject(cacheData);
}
+ _snapshotService.markRemovedSnapshot(destData.getId());
Review comment:
I think having the snapshot marked as removed here in the case of any
exception is better than just checking for a timeout. I think if the process
fails for any reason we would want to keep the db records.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
