davidjumani commented on a change in pull request #4501:
URL: https://github.com/apache/cloudstack/pull/4501#discussion_r530297887
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java
##########
@@ -114,7 +114,7 @@
+ "rule will be created for. Required when public Ip address is not
associated with any Guest network yet (VPC case)")
private Long networkId;
- @Parameter(name = ApiConstants.PROTOCOL, type = CommandType.STRING,
description = "The protocol for the LB such as tcp, udp or tcp-proxy.")
+ @Parameter(name = ApiConstants.PROTOCOL, type = CommandType.STRING,
description = "The protocol for the LB such as tcp or tcp-proxy.")
private String lbProtocol;
Review comment:
@weizhouapache good point, I'll move the check to the
NetworkHelperImpl.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
