DaanHoogland commented on a change in pull request #4525:
URL: https://github.com/apache/cloudstack/pull/4525#discussion_r539111603
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1499,7 +1499,10 @@ public void destroyPatchVbd(final Connection conn, final
String vmName) throws X
final Set<VBD> vbds = vm.getVBDs(conn);
for (final VBD vbd : vbds) {
if (vbd.getType(conn) == Types.VbdType.CD) {
- vbd.eject(conn);
+ if (!vbd.getEmpty(conn)) {
Review comment:
agree that it makes sense, but I don't see why this yields the bug
@vladimirpetrov saw. However if this fixes it for him, i'm all :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
