DaanHoogland commented on a change in pull request #4516:
URL: https://github.com/apache/cloudstack/pull/4516#discussion_r539967649
##########
File path:
plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
##########
@@ -133,7 +133,7 @@ public DataStore initialize(Map<String, Object> dsInfos) {
String providerName = (String)dsInfos.get("providerName");
HypervisorType hypervisorType = HypervisorType.None;
if(dsInfos.containsKey("hypervisorType")) {
- hypervisorType =
HypervisorType.getType((String)dsInfos.get("hypervisorType"));
+ hypervisorType =
HypervisorType.getType(dsInfos.get("hypervisorType").toString());
Review comment:
casting to String and calling toString() on an object would only be
different if toString() is not implemented @alexandru-bagu . What are you
aiming for here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
