alexandru-bagu edited a comment on pull request #4516: URL: https://github.com/apache/cloudstack/pull/4516#issuecomment-739844391
Are https://github.com/apache/cloudstack/blob/e5c29c392e5fa00653c7b7a1ea8d3fbd6b8b974f/engine/storage/integration-test/src/test/java/org/apache/cloudstack/storage/test/VolumeServiceTest.java#L264 and https://github.com/apache/cloudstack/blob/e5c29c392e5fa00653c7b7a1ea8d3fbd6b8b974f/engine/storage/integration-test/src/test/java/org/apache/cloudstack/storage/test/VolumeServiceTest.java#L311 not using the API in question? Also looking through the code, this does not look ok: using HypervisorType: https://github.com/apache/cloudstack/blob/e5c29c392e5fa00653c7b7a1ea8d3fbd6b8b974f/server/src/main/java/com/cloud/storage/StorageManagerImpl.java#L619 using String: https://github.com/apache/cloudstack/blob/e5c29c392e5fa00653c7b7a1ea8d3fbd6b8b974f/server/src/main/java/com/cloud/storage/StorageManagerImpl.java#L725 This is at first glance. Since I am new to CloudStack architecture I cannot say for certain that both those calls are to the same _initialize_ function but it looks like that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
