weizhouapache commented on pull request #4527: URL: https://github.com/apache/cloudstack/pull/4527#issuecomment-742378487
> @weizhouapache @rhtyd I see how this can bug a purist, but this is not really a critical bug is it? if so it is for milestone 4.14.1 . cc @sureshanaparti . Did i interpret my testing of #4497 wrong? @DaanHoogland let me explain what are the behaviors Assume vm has 3 cpu cores, 1. in older versions, (1) by default, there is no cpu topology in vm definition (2) if add vm setting "cpu.corespersocket" = 1, then in vm definition there should be ```<topology sockets='3' cores='1' threads='1'/>``` but it is missing. 2. #4497 fixes the issue in (2), but it also changes the default setting in (1). there are ```<topology sockets='3' cores='1' threads='1'/>``` in both (1) and (2) above. 3. this pr reset the default setting in (1). there will be no cpu topology in vm definition, if cpu.corespersocket is not set. I have no idea how critical this issue is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
