lujiefsi commented on pull request #4537:
URL: https://github.com/apache/cloudstack/pull/4537#issuecomment-744294045


   > I still don't agree, we don't enable trace logs in production unless we're 
investigating something. It may be a useful property to see 
unmasked/unsanitised data. Instead if there's any specific VO or job or command 
parameter that shouldn't be logged, it should be fixed there than a general 
fix; for example explicit log off annoation for a command can be done like 
this: 
https://github.com/apache/cloudstack/blob/master/core/src/main/java/org/apache/cloudstack/ca/SetupKeyStoreCommand.java#L31
   > 
   > Let's revisit this towards 4.16.
   
   It looks like a good solution!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to