DaanHoogland commented on a change in pull request #4399:
URL: https://github.com/apache/cloudstack/pull/4399#discussion_r542401215



##########
File path: engine/schema/src/main/java/com/cloud/host/HostVO.java
##########
@@ -740,6 +743,18 @@ public void setUuid(String uuid) {
         this.uuid = uuid;
     }
 
+    public boolean checkHostServiceOfferingTags(ServiceOffering 
serviceOffering){
+        if (serviceOffering == null) {
+            return false;
+        }
+        if (Strings.isNullOrEmpty(serviceOffering.getHostTag())) {

Review comment:
       sorry to keep nagging you, but we have a string utils proxy class in 
place. It has an isEmpty() that does the same check. if for some reason you 
need this one anyway , please add it there if the functioonality doesn't 
suffice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to