DaanHoogland commented on a change in pull request #4557:
URL: https://github.com/apache/cloudstack/pull/4557#discussion_r547316064
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -1073,6 +1073,10 @@ public static VMwareDVSPvlanConfigSpec
createDVPortPvlanConfigSpec(int vlanId, i
}
public static VmwareDistributedVirtualSwitchVlanSpec
createDVPortVlanSpec(Integer vlanId, String vlanRange) {
+ if (vlanId != null && vlanId == 4095){
+ vlanId = null;
+ vlanRange = "0-4094";
+ }
Review comment:
yes, i understand the function of `vlandId == 4095` but my point is that
it will be possible to pass `vlanId == null` and `range ==
'2-9,15-99,4000-4094'` or even `range == '4000-4095'`, and should we correct
that combination of parameters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
