DaanHoogland commented on a change in pull request #4565:
URL: https://github.com/apache/cloudstack/pull/4565#discussion_r551792810
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
##########
@@ -84,7 +84,11 @@ public boolean parseDomainXML(String domXML) {
String authUserName = getAttrValue("auth", "username",
disk);
String poolUuid = getAttrValue("secret", "uuid", disk);
String host = getAttrValue("host", "name", disk);
- int port = Integer.parseInt(getAttrValue("host", "port",
disk));
+ int port = 0;
+ String _xmlPort = getAttrValue("host", "port", disk);
+ if ( ! _xmlPort.isEmpty()) {
Review comment:
I did an investigation of the dom code used in `getAttrValue()` and it
returns an empty string if the element `"host"` does not have an attribute
named `"port"`, so _xmlPort will not be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
