mib1185 commented on a change in pull request #4574:
URL: https://github.com/apache/cloudstack/pull/4574#discussion_r553885547
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -801,9 +801,9 @@ INSERT INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervisor_vers
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type,
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined)
VALUES (UUID(),'VMware', '6.7.3', 'opensuse64Guest', 326, now(), 0);
--- Add SCO OpenServer 6 as support guest os
-INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created)
VALUES (327, UUID(), 7, 'SCO OpenServer 6', now());
--- SCO OpenServer 6 VMWare guest os mapping
+-- Add OpenSUSE Linux as support guest os
+INSERT INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, created)
VALUES (327, UUID(), 7, 'OpenSUSE Linux', now());
+-- OpenSUSE Linux VMWare guest os mapping
Review comment:
I´m a little bit confused, because the behaviour of adding/not adding
(32-bit) is inconsistent already in this single db-schema upgrade file - for
example:
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L593
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L594
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L620
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L631
---
and opposite
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L718
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L729
---
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L749
https://github.com/apache/cloudstack/blob/015bb20caaabd82774fa3fb261787ef4be9ee90d/engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql#L760
So, what should I use as template?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
