DaanHoogland commented on a change in pull request #4576:
URL: https://github.com/apache/cloudstack/pull/4576#discussion_r559638176
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2247,8 +2247,8 @@ public LibvirtVMDef createVMFromSpec(final
VirtualMachineTO vmTO) {
if (MapUtils.isNotEmpty(customParams) &&
customParams.containsKey(GuestDef.BootType.UEFI.toString())) {
guest.setBootType(GuestDef.BootType.UEFI);
guest.setBootMode(GuestDef.BootMode.LEGACY);
+ guest.setMachineType("q35");
Review comment:
should we make assumptions about running on intel platforms and/or would
that hurt? cc @wido @rhtyd #raspberryrules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
