rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561167971
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service
debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
Yes that adds a dependency much like jdk or mvn. I've added nodejs-12
(lts) in the container images that are used to build packages by blueorangutan.
https://hub.docker.com/u/bhaisaab
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
