sureshanaparti commented on pull request #4604: URL: https://github.com/apache/cloudstack/pull/4604#issuecomment-765298577
> > @shwstppr I do understand that it is good to display name(s) of resources/entities in the UI. But, I think, to change the respective API responses to include the name(s) of the required resources/entities (to show in the UI) may not be the right thing. The UUIDs can be further used with the list API(s) to get the required details (name, zone, etc) to fill the UI as desired. > > If we continue this exercise to show name(s) in the UI, finally we end up adding name(s) to most of the responses. > > I know UI has to attempt multiple API calls, but API responses should primarly return UUIDs. For names and other details, make use of list API calls. > > @sureshanaparti I may agree with you on that partly but changes aren't causing any additional db query, plus we have similar parameters in other api responses so maybe this can be allowed ;) > Calling list api just for names in UI will be an overkill @shwstppr So, do you mean it is the right approach to consider the API response object parameters for UI display? Few recent PRs below, with such changes where the response parameters are mainly updated for UI display only. https://github.com/apache/cloudstack/pull/4483 - updated listNetworks API response for VPC Name https://github.com/apache/cloudstack/pull/4275 - updated listVmSnapshot API response for Hypervisor https://github.com/apache/cloudstack/pull/4073 - updated listPublicIpAddress API response for Network Name ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
