weizhouapache commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r563719624



##########
File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
##########
@@ -70,20 +76,33 @@ function install_packages() {
     radvd \
     sharutils genisoimage aria2 \
     strongswan libcharon-extra-plugins libstrongswan-extra-plugins 
strongswan-charon strongswan-starter \
-    virt-what open-vm-tools qemu-guest-agent hyperv-daemons
+    virt-what open-vm-tools qemu-guest-agent hyperv-daemons cloud-guest-utils \
+    apt-transport-https ca-certificates curl gnupg  gnupg-agent 
software-properties-common cloud-init
 
   apt-get -y autoremove --purge
   apt-get clean
   apt-get autoclean
 
+  apt_clean
   ${apt_get} install links
 
+   curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -
+   apt-key fingerprint 0EBFCD88
+
   #32 bit architecture support for vhd-util: not required for 32 bit template
   if [ "${arch}" != "i386" ]; then
     dpkg --add-architecture i386
     apt-get update
     ${apt_get} install libuuid1:i386 libc6:i386
+
+    add-apt-repository \
+    "deb [arch=amd64] https://download.docker.com/linux/debian \
+    $(lsb_release -cs) \
+    stable"
+    apt-get update
+    ${apt_get} install docker-ce docker-ce-cli containerd.io

Review comment:
       @Pearl1594 
   we could have different template for cks. debian9 is one of an options for 
cks template. if cloudstack users want to have centos8 or ubuntu 2004 as cks 
template,we could build them as well.
   we can create separated folder in tools/appliance/, like 
cks-template-debian10, cks-template-centos8, etc
   
   if we use same template on VR and cks, and we need to make more changes in 
the template, it will impact the systemvm and vrs as well. cloudstack systemvm 
template is quite stable now. do not touch it if possible.
   in addition, some packages in systemvm template are not needed for cks.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to