weizhouapache commented on pull request #4602: URL: https://github.com/apache/cloudstack/pull/4602#issuecomment-767442932
> > @weizhouapache that's the adv zone created by https://github.com/apache/cloudstack/blob/master/setup/dev/advanced.cfg but it would be a good idea to test SG envs as well > > @rhtyd thanks. I will investigate it. @shwstppr I check the source code, the logic is (1) if there is no network in api request, (1.1) if the first nic of old vm is Shared and can be used by new user, then use it as default. (1.2) if first nic is not Shared or cannot be used by new user, then create a new isolated network (advanced zone) or throw exception (advanced zone with security groups). (2) if there is a list of networks in api request, (2.1) check if new user can use the networks. (2.2) if not, throw an exception. this pr fixes 1. vm nics after moving are not in same order as networks in the list in api request. 2. vm nics ip on same Shared network are changed after moving. hence I think your testing result is same as expected. you can try to add a list of networks in the cloudmonkey command. I will add a commit to take L2 network into consideration. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
