ustcweizhou opened a new pull request #4624: URL: https://github.com/apache/cloudstack/pull/4624
### Description This PR fixes wrong message when create isolated network without SourceNat When I created network without sourcenat, I got message below ``` (localcloud) 🐱 > create network name=fully-isolated-noservices displaytext=fully-isolated-noservices networkofferingid=83f13c21-38fd-439f-a0fc-54d6d5233fec zoneid=70e90072-db05-42c0-a639-71d16d905406 🙈 Error: (HTTP 431, error code 4350) StartIp/endIp/gateway/netmask are required when create network of type Shared and network of type Isolated with service SourceNat disabled ``` However, when I passed StartIp/endIp/gateway/netmask, it also failed. ``` (localcloud) 🐱 > create network name=fully-isolated-noservices displaytext=fully-isolated-noservices networkofferingid=83f13c21-38fd-439f-a0fc-54d6d5233fec zoneid=70e90072-db05-42c0-a639-71d16d905406 startip=192.168.101.2 endip=192.168.101.20 gateway=192.168.101.1 netmask=255.255.255.0 🙈 Error: (HTTP 431, error code 4350) Network offering with specified id doesn't support adding multiple ip ranges ``` without startip/endip, the following worked. ``` create network name=fully-isolated-noservices displaytext=fully-isolated-noservices networkofferingid=83f13c21-38fd-439f-a0fc-54d6d5233fec zoneid=70e90072-db05-42c0-a639-71d16d905406 gateway=192.168.102.1 netmask=255.255.255.0 ``` <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
