Author: sebb
Date: Sat Mar 14 16:03:31 2009
New Revision: 754470
URL: http://svn.apache.org/viewvc?rev=754470&view=rev
Log:
Make private fields final
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableDelegate.java
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableError.java
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableException.java
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableRuntimeException.java
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableDelegate.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableDelegate.java?rev=754470&r1=754469&r2=754470&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableDelegate.java
(original)
+++
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableDelegate.java
Sat Mar 14 16:03:31 2009
@@ -65,7 +65,7 @@
* wrapping (which must be a {...@link
* org.apache.commons.lang.exception.Nestable} implementation).
*/
- private Throwable nestable = null;
+ private final Throwable nestable;
/**
* Whether to print the stack trace top-down.
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableError.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableError.java?rev=754470&r1=754469&r2=754470&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableError.java
(original)
+++
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableError.java
Sat Mar 14 16:03:31 2009
@@ -40,13 +40,14 @@
* The helper instance which contains much of the code which we
* delegate to.
*/
+ // TODO make final
protected NestableDelegate delegate = new NestableDelegate(this);
/**
* Holds the reference to the exception or error that caused
* this exception to be thrown.
*/
- private Throwable cause = null;
+ private final Throwable cause;
/**
* Constructs a new <code>NestableError</code> without specified
@@ -54,6 +55,7 @@
*/
public NestableError() {
super();
+ this.cause = null;
}
/**
@@ -64,6 +66,7 @@
*/
public NestableError(String msg) {
super(msg);
+ this.cause = null;
}
/**
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableException.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableException.java?rev=754470&r1=754469&r2=754470&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableException.java
(original)
+++
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableException.java
Sat Mar 14 16:03:31 2009
@@ -100,13 +100,14 @@
* The helper instance which contains much of the code which we
* delegate to.
*/
+ // TODO make final
protected NestableDelegate delegate = new NestableDelegate(this);
/**
* Holds the reference to the exception or error that caused
* this exception to be thrown.
*/
- private Throwable cause = null;
+ private final Throwable cause;
/**
* Constructs a new <code>NestableException</code> without specified
@@ -114,6 +115,7 @@
*/
public NestableException() {
super();
+ this.cause = null;
}
/**
@@ -124,6 +126,7 @@
*/
public NestableException(String msg) {
super(msg);
+ this.cause = null;
}
/**
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableRuntimeException.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableRuntimeException.java?rev=754470&r1=754469&r2=754470&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableRuntimeException.java
(original)
+++
commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/NestableRuntimeException.java
Sat Mar 14 16:03:31 2009
@@ -44,13 +44,14 @@
* The helper instance which contains much of the code which we
* delegate to.
*/
+ // TODO make final
protected NestableDelegate delegate = new NestableDelegate(this);
/**
* Holds the reference to the exception or error that caused
* this exception to be thrown.
*/
- private Throwable cause = null;
+ private final Throwable cause;
/**
* Constructs a new <code>NestableRuntimeException</code> without specified
@@ -58,6 +59,7 @@
*/
public NestableRuntimeException() {
super();
+ this.cause = null;
}
/**
@@ -68,6 +70,7 @@
*/
public NestableRuntimeException(String msg) {
super(msg);
+ this.cause = null;
}
/**
