Author: sebb
Date: Sat Mar 14 16:04:17 2009
New Revision: 754471
URL: http://svn.apache.org/viewvc?rev=754471&view=rev
Log:
Make private fields final
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
commons/proper/lang/trunk/src/test/org/apache/commons/lang/BitFieldTest.java
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java?rev=754471&r1=754470&r2=754471&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
(original)
+++
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
Sat Mar 14 16:04:17 2009
@@ -102,7 +102,7 @@
*
* @since 2.3
*/
- private static ThreadLocal registry = new ThreadLocal() {
+ private static final ThreadLocal registry = new ThreadLocal() {
@Override
protected Object initialValue() {
// The HashSet implementation is not synchronized,
Modified:
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754471&r1=754470&r2=754471&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
(original)
+++
commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Sat Mar 14 16:04:17 2009
@@ -133,7 +133,7 @@
* to detect cyclical object references and avoid infinite loops.
* </p>
*/
- private static ThreadLocal registry = new ThreadLocal() {
+ private static final ThreadLocal registry = new ThreadLocal() {
@Override
protected Object initialValue() {
// The HashSet implementation is not synchronized,
Modified:
commons/proper/lang/trunk/src/test/org/apache/commons/lang/BitFieldTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/org/apache/commons/lang/BitFieldTest.java?rev=754471&r1=754470&r2=754471&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/test/org/apache/commons/lang/BitFieldTest.java
(original)
+++
commons/proper/lang/trunk/src/test/org/apache/commons/lang/BitFieldTest.java
Sat Mar 14 16:04:17 2009
@@ -41,9 +41,9 @@
return suite;
}
- private static BitField bf_multi = new BitField(0x3F80);
- private static BitField bf_single = new BitField(0x4000);
- private static BitField bf_zero = new BitField(0);
+ private static final BitField bf_multi = new BitField(0x3F80);
+ private static final BitField bf_single = new BitField(0x4000);
+ private static final BitField bf_zero = new BitField(0);
/**
* Constructor BitFieldTest
