This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new dee9ac8e Don't initialize an instance variable to its default value
dee9ac8e is described below

commit dee9ac8ec440c488b92977844a4632ecc1e3eca4
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Oct 27 09:02:08 2023 -0400

    Don't initialize an instance variable to its default value
---
 .../apache/commons/compress/archivers/zip/ZipArchiveEntry.java    | 2 +-
 .../org/apache/commons/compress/harmony/pack200/ClassBands.java   | 6 +++---
 .../org/apache/commons/compress/harmony/pack200/NewAttribute.java | 8 ++++----
 .../commons/compress/harmony/pack200/NewAttributeBands.java       | 2 +-
 .../org/apache/commons/compress/harmony/pack200/PackingUtils.java | 2 +-
 .../compress/utils/MultiReadOnlySeekableByteChannelTest.java      | 2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java 
b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
index d3e11a82..ab3e0e36 100644
--- 
a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
+++ 
b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
@@ -290,7 +290,7 @@ public class ZipArchiveEntry extends java.util.zip.ZipEntry 
implements ArchiveEn
 
     private long diskNumberStart;
 
-    private boolean lastModifiedDateSet = false;
+    private boolean lastModifiedDateSet;
 
     private long time = -1;
 
diff --git 
a/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java 
b/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
index 3c512cc7..0e95f1a8 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/ClassBands.java
@@ -188,10 +188,10 @@ public class ClassBands extends BandSet {
 
        private TempParamAnnotation tempMethodRVPA;
        private TempParamAnnotation tempMethodRIPA;
-       private boolean anySyntheticClasses = false;
-       private boolean anySyntheticFields = false;
+       private boolean anySyntheticClasses;
+       private boolean anySyntheticFields;
 
-       private boolean anySyntheticMethods = false;
+       private boolean anySyntheticMethods;
        private final Segment segment;
 
        private final Map<CPClass, Set<CPClass>> classReferencesInnerClass = 
new HashMap<>();
diff --git 
a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttribute.java 
b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttribute.java
index d5c30fc8..6882ad37 100644
--- 
a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttribute.java
+++ 
b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttribute.java
@@ -80,11 +80,11 @@ public class NewAttribute extends Attribute {
             return null;
         }
     }
-    private boolean contextClass = false;
+    private boolean contextClass;
 
-    private boolean contextMethod = false;
-    private boolean contextField = false;
-    private boolean contextCode = false;
+    private boolean contextMethod;
+    private boolean contextField;
+    private boolean contextCode;
     private final String layout;
     private byte[] contents;
     private int codeOff;
diff --git 
a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
 
b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
index c4cb47e2..404f8ef4 100644
--- 
a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
+++ 
b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
@@ -295,7 +295,7 @@ public class NewAttributeBands extends BandSet {
 
         private List<ConstantPoolEntry> band;
 
-        private boolean nullsAllowed = false;
+        private boolean nullsAllowed;
 
         public Reference(final String tag) {
             this.tag = tag;
diff --git 
a/src/main/java/org/apache/commons/compress/harmony/pack200/PackingUtils.java 
b/src/main/java/org/apache/commons/compress/harmony/pack200/PackingUtils.java
index 38a0b6a5..046f35ab 100644
--- 
a/src/main/java/org/apache/commons/compress/harmony/pack200/PackingUtils.java
+++ 
b/src/main/java/org/apache/commons/compress/harmony/pack200/PackingUtils.java
@@ -43,7 +43,7 @@ public class PackingUtils {
 
     private static final class PackingLogger extends Logger {
 
-        private boolean verbose = false;
+        private boolean verbose;
 
         protected PackingLogger(final String name, final String 
resourceBundleName) {
             super(name, resourceBundleName);
diff --git 
a/src/test/java/org/apache/commons/compress/utils/MultiReadOnlySeekableByteChannelTest.java
 
b/src/test/java/org/apache/commons/compress/utils/MultiReadOnlySeekableByteChannelTest.java
index f690eef7..91b9092d 100644
--- 
a/src/test/java/org/apache/commons/compress/utils/MultiReadOnlySeekableByteChannelTest.java
+++ 
b/src/test/java/org/apache/commons/compress/utils/MultiReadOnlySeekableByteChannelTest.java
@@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test;
 public class MultiReadOnlySeekableByteChannelTest {
 
     private static final class ThrowingSeekableByteChannel implements 
SeekableByteChannel {
-        private boolean closed = false;
+        private boolean closed;
         @Override
         public void close() throws IOException {
             closed = true;

Reply via email to